Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Metabase to v0.41.0 #53

Draft
wants to merge 665 commits into
base: master
Choose a base branch
from
Draft

Conversation

r351574nc3
Copy link

Changes

  • Merged v0.41.0 changes from upstream repository
  • Adding docker build and push job for CircleCI to push tagged images.

pawit-metabase and others added 30 commits September 8, 2021 10:37

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* let users disable attachments with questions checked

* use more declarative assertions in unit tests

* use aria-label over testid

* translate aria label

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…n moving between sidebar views (metabase#17791)

* don't set pulse on SharingSidebar mount

* remove some old, unused code

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…etabase#17761)

Merging on behalf of Nemanja

* Attempt to fix metabase#17751

* Revert limiting max-width on a parent div

* Inherit min-width from a parent div

* Unskip repro

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Pass along date formatting

* extract and rename some things

* Number formatting

* Update tests

* Improve test validation of svg labels

* Clean up tests

* Move static-viz interface file to custom file

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…y access to a collection (metabase#17722)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* don't show exact seconds for a formatted relative time

* add a couple of getRelativeTimeAbbreviated tests

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
There's more to come WRT the audits, but anton and I agreed to merge something faster and work on that stuff after

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This was a miserable grind in the old BQ syntax but a happy fun time in the new BQ syntax, basically just turning it on and squashing a bunch of test bugs.

One test bug to note especially is that the underscore-transformed set of bird scarcity data for the bird scarcity tests is actually necessary, because BQ will hit you with a complaint about underscores even if you successfully and correctly quote the table names.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Basic skeleton of front-end dependencies analyzer

* Parse enterprise/frontend

* Handle good ol' require

* For sanity, bail out immediately when encountering a parse errr

* Split into commands (currently returning JSON)

* Filter dependents from stdin

* Track down all dependents, including the indirect/transitive ones

* Fix filtering not including the enterprise

* Map a directory to its index.js, if it exists

* Refactor common functions

* Matrix and count dependents

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* raw tags

* index to start

* update toc link

* reference link

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Add parameter handling for BigDecimal that checks whether the value is in range for BIGNUMERIC or BIGDECIMAL and sets accordingly

Updating parameter test to hit both these cases

Modifying test code/macros to support a with-table semantic for testing the decimal types via a temp table

Writing new test to confirm that all numeric types are synced correctly and can be queried for

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
github-actions bot and others added 26 commits October 5, 2021 17:00

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* restyle the Verify button

* remove unused components

* make the verify button blue

Co-authored-by: Maz Ameli <maz@metabase.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…et" (metabase#18263)

* Fix virtual fields are missing in ParameterValueWidget

* fix fk filter parameters

Co-authored-by: Alexander Lesnenko <alxnddr@users.noreply.github.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Maz Ameli <maz@metabase.com>
…8237)

* Fix Dashboard Subscription email validation (second pass)

* Always validate Pulse channels in test endpoint
…g in order clause (metabase#18221)

Remove the `driver/format-custom-field-name` implementation for :snowflake, which was causing the problem and appears to be no longer needed anyway

Add test for this scenario to `metabase.query-processor-test.expression-aggregations-test`

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…tabase#18274)

Co-authored-by: Justin McCarthy <justin@strongdm.com>
Co-authored-by: Pawit Pornkitprasan <pawit@metabase.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Add `setupSMTP` helper function

* Remove deprecated `setupDummySMTP` helper

* Re-use `setupSMTP` helper in tests

* Always clear Webmail's inbox after setting up the SMTP

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
metabase#18270) (metabase#18296)

Change implementation of docsUrl to handle RC suffixes for EE versions

Change the regex used to test the tag to detect any OSS or EE version, including (possibly) an arbitrary suffix after the major and minor parts, and normalize to the major OSS equivalent version instead.  If the suffix, OTOH, is `-SNAPSHOT` (ignoring case), then the doc tag will be `latest`, on the theory that this is as local development build.

v0.41.0 => v0.41
v1.41.1 => v0.41
v1.41.2-RC1 => v0.41
v1.42.0-SNAPSHOT => latest

Adding unit tests for all cases

Update behavior so that -SNAPSHOT suffix points to "latest"

Co-authored-by: Jeff Evans <jeff303@users.noreply.github.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com>
Previous PRs for error cards page were laser focused on getting everything to work, as opposed to actually conforming to spec. This one gets it closer to spec, although product wants reloading animations which are not there yet. To wit,

- Indicates to end user what the current running state is. Given the many orders of magnitude in DB query run times I think something robust and non-ephemeral is necessary here (looking at some sort of expanded QE model) but Maz suggested expedient method and I took it
- No more left nav on the table page
- Page heading for table page
- Independent scroll-x behavior on the table
- Styling for the error section on the table page
- Select-all component. Note that the interaction behavior with pagination is fiddly. (but less fiddly now that it's all based on card id's instead of row numbers)
- Coalescing default behavior for Our Analytics collection (default collection) and null number of dashboards
Rename error name to error content search
* Static viz: respect custom X and Y axis labels

* Static viz: allow rendering non-timeseries line charts

* Test fixes 🔧

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature.
r351574nc3 Leo (중광) Przybylski
v0.41.0

Verified

This commit was signed with the committer’s verified signature.
r351574nc3 Leo (중광) Przybylski

Verified

This commit was signed with the committer’s verified signature.
r351574nc3 Leo (중광) Przybylski

Verified

This commit was signed with the committer’s verified signature.
r351574nc3 Leo (중광) Przybylski

Verified

This commit was signed with the committer’s verified signature.
r351574nc3 Leo (중광) Przybylski

Verified

This commit was signed with the committer’s verified signature.
r351574nc3 Leo (중광) Przybylski

Verified

This commit was signed with the committer’s verified signature.
r351574nc3 Leo (중광) Przybylski

Verified

This commit was signed with the committer’s verified signature.
r351574nc3 Leo (중광) Przybylski

Verified

This commit was signed with the committer’s verified signature.
r351574nc3 Leo (중광) Przybylski
@r351574nc3 r351574nc3 force-pushed the feat/circleci-image-build branch from 0e9bb5a to 122f660 Compare November 15, 2023 20:44

Verified

This commit was signed with the committer’s verified signature.
r351574nc3 Leo (중광) Przybylski
@r351574nc3 r351574nc3 force-pushed the feat/circleci-image-build branch from 122f660 to 002c25d Compare November 15, 2023 20:54

Verified

This commit was signed with the committer’s verified signature.
r351574nc3 Leo (중광) Przybylski
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet